PMD Results

The following document contains the results of PMD 7.19.0.

Violations By Priority

Priority 4

org/tailormap/api/controller/admin/SolrAdminController.java

Rule Violation Line
UselessParentheses Useless parentheses around `null == searchIndex.getLastIndexed() || searchI...`. 200
UselessParentheses Useless parentheses around `null != searchIndex.getSchedule() && null != se...`. 202–203
UselessParentheses Useless parentheses around `createNewIndex ? "creation of a new" : "update of"`. 227

org/tailormap/api/controller/admin/TaskAdminController.java

Rule Violation Line
UselessParentheses Useless parentheses around `null == type ? "all" : type`. 113
UselessParentheses Useless parentheses around `null == type ? GroupMatcher.anyGroup() : GroupM...`. 117
UselessParentheses Useless parentheses around `(CronTrigger) trigger`. 223
UselessParentheses Useless parentheses around `succes ? "succeeded" : "failed"`. 401

org/tailormap/api/drawing/DrawingService.java

Rule Violation Line
UselessParentheses Useless parentheses around `authentication instanceof AnonymousAuthenticati...`. 422

org/tailormap/api/geotools/featuresources/AttachmentsHelper.java

Rule Violation Line
UselessParentheses Useless parentheses around `attachmentAttributeType.getAttributeName() == n...`. 164–165
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AttachmentsHelper': 'fidFromPK' is already in scope 692

org/tailormap/api/persistence/GeoService.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.tailormap.api.viewer.model': 'Service' is already in scope because it is imported in this file 312

org/tailormap/api/persistence/User.java

Rule Violation Line
UselessParentheses Useless parentheses around `8 + 60`. 56

org/tailormap/api/persistence/helper/ApplicationHelper.java

Rule Violation Line
UselessParentheses Useless parentheses around `n.getChildrenIds() != null && n.getChildrenIds(...`. 265–266

org/tailormap/api/repository/events/SearchIndexEventHandler.java

Rule Violation Line
UselessParentheses Useless parentheses around `succes ? "succeeded" : "failed"`. 71

org/tailormap/api/scheduling/IndexTask.java

Rule Violation Line
UselessParentheses Useless parentheses around `1 + (int) context.getMergedJobDataMap().getOrDe...`. 123

org/tailormap/api/scheduling/TaskType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TaskType': 'values' is already in scope 20

org/tailormap/api/security/AuthorisationService.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AuthorisationService': 'ACCESS_TYPE_VIEW' is already in scope because it is declared in an enclosing type 82
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AuthorisationService': 'ACCESS_TYPE_VIEW' is already in scope because it is declared in an enclosing type 87
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AuthorisationService': 'ACCESS_TYPE_VIEW' is already in scope because it is declared in an enclosing type 97
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AuthorisationService': 'ACCESS_TYPE_VIEW' is already in scope because it is declared in an enclosing type 106
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AuthorisationService': 'ACCESS_TYPE_VIEW' is already in scope because it is declared in an enclosing type 111
UselessParentheses Useless parentheses around `allowed ? "allowed" : "denied"`. 246
UselessParentheses Useless parentheses around `allowed ? "allowed" : "denied"`. 254

org/tailormap/api/solr/SolrHelper.java

Rule Violation Line
UselessParentheses Useless parentheses around `indexCounter - indexSkippedCounter`. 368
UselessParentheses Useless parentheses around `indexCounter - indexSkippedCounter`. 380

Files

org/tailormap/api/controller/admin/SolrAdminController.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `null == searchIndex.getLastIndexed() || searchI...`. 4 200
UselessParentheses Useless parentheses around `null != searchIndex.getSchedule() && null != se...`. 4 202–203
UselessParentheses Useless parentheses around `createNewIndex ? "creation of a new" : "update of"`. 4 227

org/tailormap/api/controller/admin/TaskAdminController.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `null == type ? "all" : type`. 4 113
UselessParentheses Useless parentheses around `null == type ? GroupMatcher.anyGroup() : GroupM...`. 4 117
UselessParentheses Useless parentheses around `(CronTrigger) trigger`. 4 223
UselessParentheses Useless parentheses around `succes ? "succeeded" : "failed"`. 4 401

org/tailormap/api/drawing/DrawingService.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `authentication instanceof AnonymousAuthenticati...`. 4 422

org/tailormap/api/geotools/featuresources/AttachmentsHelper.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `attachmentAttributeType.getAttributeName() == n...`. 4 164–165
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AttachmentsHelper': 'fidFromPK' is already in scope 4 692

org/tailormap/api/persistence/GeoService.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.tailormap.api.viewer.model': 'Service' is already in scope because it is imported in this file 4 312

org/tailormap/api/persistence/User.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `8 + 60`. 4 56

org/tailormap/api/persistence/helper/ApplicationHelper.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `n.getChildrenIds() != null && n.getChildrenIds(...`. 4 265–266

org/tailormap/api/repository/events/SearchIndexEventHandler.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `succes ? "succeeded" : "failed"`. 4 71

org/tailormap/api/scheduling/IndexTask.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `1 + (int) context.getMergedJobDataMap().getOrDe...`. 4 123

org/tailormap/api/scheduling/TaskType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TaskType': 'values' is already in scope 4 20

org/tailormap/api/security/AuthorisationService.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AuthorisationService': 'ACCESS_TYPE_VIEW' is already in scope because it is declared in an enclosing type 4 82
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AuthorisationService': 'ACCESS_TYPE_VIEW' is already in scope because it is declared in an enclosing type 4 87
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AuthorisationService': 'ACCESS_TYPE_VIEW' is already in scope because it is declared in an enclosing type 4 97
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AuthorisationService': 'ACCESS_TYPE_VIEW' is already in scope because it is declared in an enclosing type 4 106
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AuthorisationService': 'ACCESS_TYPE_VIEW' is already in scope because it is declared in an enclosing type 4 111
UselessParentheses Useless parentheses around `allowed ? "allowed" : "denied"`. 4 246
UselessParentheses Useless parentheses around `allowed ? "allowed" : "denied"`. 4 254

org/tailormap/api/solr/SolrHelper.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `indexCounter - indexSkippedCounter`. 4 368
UselessParentheses Useless parentheses around `indexCounter - indexSkippedCounter`. 4 380

Suppressed Violations

Filename Rule message Suppression type Reason
org/tailormap/api/configuration/dev/PopulateTestData.java Do not hard code the IP address '127.0.0.1' @suppresswarnings
org/tailormap/api/configuration/dev/PopulateTestData.java Do not hard code the IP address '127.0.0.1' @suppresswarnings
org/tailormap/api/configuration/dev/PopulateTestData.java Do not hard code the IP address '127.0.0.1' @suppresswarnings
org/tailormap/api/configuration/dev/PopulateTestData.java Do not hard code the IP address '127.0.0.1' @suppresswarnings
org/tailormap/api/configuration/dev/PopulateTestData.java Do not hard code the IP address '127.0.0.1' @suppresswarnings
org/tailormap/api/controller/GeoServiceProxyController.java Ensure that resources like this HttpClient object are closed after use @suppresswarnings
org/tailormap/api/geotools/wfs/WFSProxy.java Ensure that resources like this HttpClient object are closed after use @suppresswarnings
org/tailormap/api/persistence/Group.java Avoid unused private methods such as 'removeMembers()'. @suppresswarnings